Home > DeveloperSection > Forums > My Factorial program isn’t giving correct output using java
Garry Winogrand
Garry Winogrand

Total Post:24

Points:168
Posted on    October-05-2013 9:08 AM

 Java Java 
Ratings:


 1 Reply(s)
 650  View(s)
Rate this:
import java.math.BigInteger;
import java.io.*;
 
class Factorial
{
    public static void main(String args[])
    {
        try
        {
            int key;
            BufferedReader br=new BufferedReader(new InputStreamReader(System.in));
            BigInteger result=new BigInteger("1");
            //take the quantity of elements for which factorial is to be calculated
            int num=Integer.parseInt(br.readLine());
 
            while(num-->0)
            {
                //input the number for which factorial is to be calculated
                key=Integer.parseInt(br.readLine());
                while(key>0)
                {
                    System.out.println(key+""+result);
                    result.multiply(BigInteger.valueOf(key));
                    key--;
                }
                //again make the result back to 1 for next key element
                result=new BigInteger("1");
            }
        }catch(Exception e)
        {
            //do nothing
        }
    }
}


Dag Hammarskjold
Dag Hammarskjold

Total Post:24

Points:168
Posted on    October-05-2013 9:29 AM

result = result.multiply(BigInteger.valueOf(key));

Result should be printed, after perform operation in while loop. Look at modified code:

  key=Integer.parseInt(br.readLine());
  while(key>0){
       result = result.multiply(BigInteger.valueOf(key));
       key--;
  }
  System.out.println(key+" "+result);

Note: -BigInteger is immutable. result need to reassign to get desired output like:


Don't want to miss updates? Please click the below button!

Follow MindStick