MY FACTORIAL PROGRAM ISN’T GIVING CORRECT OUTPUT USING JAVA

Garry Winogrand

Total Post:24

Points:168
Posted by  Garry Winogrand
Java 
 941  View(s)
Ratings:
Rate this:
import java.math.BigInteger;
import java.io.*;
 
class Factorial
{
    public static void main(String args[])
    {
        try
        {
            int key;
            BufferedReader br=new BufferedReader(new InputStreamReader(System.in));
            BigInteger result=new BigInteger("1");
            //take the quantity of elements for which factorial is to be calculated
            int num=Integer.parseInt(br.readLine());
 
            while(num-->0)
            {
                //input the number for which factorial is to be calculated
                key=Integer.parseInt(br.readLine());
                while(key>0)
                {
                    System.out.println(key+""+result);
                    result.multiply(BigInteger.valueOf(key));
                    key--;
                }
                //again make the result back to 1 for next key element
                result=new BigInteger("1");
            }
        }catch(Exception e)
        {
            //do nothing
        }
    }
}
  1. Dag Hammarskjold

    Post:24

    Points:168
    Re: My Factorial program isn’t giving correct output using java

    result = result.multiply(BigInteger.valueOf(key));

    Result should be printed, after perform operation in while loop. Look at modified code:

      key=Integer.parseInt(br.readLine());
      while(key>0){
           result = result.multiply(BigInteger.valueOf(key));
           key--;
      }
      System.out.println(key+" "+result);

    Note: -BigInteger is immutable. result need to reassign to get desired output like:

Answer

NEWSLETTER

Enter your email address here always to be updated. We promise not to spam!