forum

Home / DeveloperSection / Forums / code optimized in c#

Ask Question

code optimized in c#

Anonymous User 3241 16-Nov-2012
hello every one,

public static int SetSelectedItem(string[] sValues)
        {
            int nRow = 0;
            try
            {
                foreach (string str in sValues)
                {
                    SqlCommand cmdUpdate = new SqlCommand("UPDATE [dbo].[tblProductsManager] SET IsActive = 1 WHERE Id= '" + str + "' ", con);
                    if (con.State == ConnectionState.Closed)
                        con.Open();
                    nRow = cmdUpdate.ExecuteNonQuery();
                }
            }
            catch { }
            finally
            {
                if (con.State == ConnectionState.Open)
                    con.Close();
            }
            return nRow;
        }

in the above code, "cmdUpdate.ExecuteNonQuery();" call for every value of "sValues".

i want, "cmdUpdate.ExecuteNonQuery();" execute only one time for all array value.
if have any idea, plz help me.
c# c# 
Updated on 19-Nov-2012
Anonymous User

Anonymous User

Follow
I am a content writter !

Can you answer this question?

Answer

2 Answers

Anonymous User

Anonymous User

19-Nov-2012


It resolve my problem

Thanks
Anonymous User

Anonymous User

19-Nov-2012
Hi Goti Bandhu,
You can use StringBuilder concept here, replace your code with following code:
public static int SetSelectedItem(string[] sValues)
        {
            int nRow = 0;
            try
            {
               StringBuilder sqlQuery = new StringBuilder ();
               sqlQuery.Append("UPDATE [dbo].[tblProductsManager] SET IsActive = 1 WHERE Id in '('");
          foreach (string str in sValues)
                {
                    sqlQuery.Append(str+"'," );
                    
                }
               sqlQuery.Append("')" );
              SqlCommand cmdUpdate = new SqlCommand ( sqlQuery.ToString(), con);
                   if (con.State == ConnectionState.Closed)
                         con.Open();
                     nRow = cmdUpdate.ExecuteNonQuery();
            }
            catch { }
            finally
            {
                if (con.State == ConnectionState.Open)
                    con.Close();
            }
            return nRow;
        }
Please mark as answer if this code will resolve your problem.

Liked By